[PATCH] D76073: [compiler-rt][tsan] Fix: Leak of ThreadSignalContext memory mapping when destroying fibers.

[Dmitry Vyukov via Phabricator via llvm-commits]

dvyukov added a comment.

> I would appreciate feedback if this way of fixing the leak is ok.

It looks ok to me.
As you noted below the shutdown sequence is quite messy...

> Also, I think it would be worthwhile to more closely look at the lifecycle of ThreadState (i.e. it uses no constructor/destructor, thus requiring manual callbacks for cleanup) and how OS-Threads/user level fibers are differentiated in the codebase. I would be happy to contribute more if someone could point me at the right place to discuss this issue.

thread-sanitizer at googlegroups.com mailing list is the right place. Or, we can discuss prototype changes here.

Thanks


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76073/new/

https://reviews.llvm.org/D76073