[PATCH] D76499: [obj2yaml] - Simplify and reduce `ELFDumper<ELFT>::dumpSections`. NFCI.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 20 08:05:36 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/tools/obj2yaml/elf2yaml.cpp:251
+  auto GetDumper = [&, this](unsigned Type)
+      -> std::function<Expected<ELFYAML::Chunk *>(const Elf_Shdr *)> {
+    switch (Type) {
----------------
std::function<...> is not needed. How about returning a pointer to class member function?




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76499/new/

https://reviews.llvm.org/D76499





More information about the llvm-commits mailing list