[PATCH] D74977: [WIP][RISCV][GlobalISel] Add lowerFormalArguments for calling convention

[Joseph Faulls via Phabricator via llvm-commits]

Joe added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVCallLowering.cpp:171
+      continue;
+    if (Arg.getType()->isPointerTy())
+      continue;
----------------
Perhaps add a test for this?


================
Comment at: llvm/lib/Target/RISCV/RISCVCallLowering.cpp:173
+      continue;
+    if (Arg.getType()->isFloatingPointTy())
+      continue;
----------------
Floats don't work here. HandleAssignments tries to truncate it. Best to leave it unsupported for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74977/new/

https://reviews.llvm.org/D74977