[PATCH] D76401: [PowerPC][AIX] ByVal formal argument support: single register.

[Sean Fertile via Phabricator via llvm-commits]

sfertile marked 3 inline comments as done.
sfertile added a comment.

I'm going to implement the suggested changes to the testing (ie a zero-sized-byval  and different byval types so we are loading more then just a char). I'll do so in a separate patch which makes the changes and shows the difference in the existing tests and then I'll rebase this patch onto that.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7070
+      if (TrueSize > PtrByteSize)
+        report_fatal_error(
+            "Formal arguments greater then register size not implemented yet.");
----------------
ZarkoCA wrote:
> There is already a fatal error in CC_AIX for this, would an assert be better here? 
That fatal error is going to go away in the next patch implementing multiple registers on the caller side so I have a similar error here so we don't have to change this function in that patch. I can remove it if you want though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76401/new/

https://reviews.llvm.org/D76401