[PATCH] D76434: [SCEV] Query for immediate cost in Expander

[Sam Parker via Phabricator via llvm-commits]

samparker added a comment.

> Do we model rthrougput for constants elsewhere?

I guess that depends on who 'we' are because, again, different backends will be modelling different things. Why the focus on throughput now anyway? When this code was using getOperationCost, it would have been getting some performance/code size cost, which I expect most backends will be modelling for constants. And I'm not really sure why throughput is specifically important here, we're not concerning ourselves with the throughput of casts and compares, right?

> Let's take a step back here. How about we simply revert D73501 <https://reviews.llvm.org/D73501>?

Sounds good to me, although I still need to prod around here to see if codegen risk being erratic in the future.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76434/new/

https://reviews.llvm.org/D76434