[PATCH] D76483: [DivRemPairs] Freeze operands if they can be undef values
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 20 05:23:34 PDT 2020
spatel added inline comments.
================
Comment at: llvm/lib/Transforms/Scalar/DivRemPairs.cpp:318
+ if (!isGuaranteedNotToBeUndefOrPoison(X, DivInst, &DT)) {
+ auto FrX = new FreezeInst(X, X->getName() + ".frozen", DivInst);
+ DivInst->setOperand(0, FrX);
----------------
I think this should either be "FreezeInst *" or "auto *" to conform to LLVM coding conventions. (Same for line 325).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76483/new/
https://reviews.llvm.org/D76483
More information about the llvm-commits
mailing list