[PATCH] D76007: [TableGen][GlobalISel] Account for HwMode in RegisterBank register sizes

[Adrian Kuegel via Phabricator via llvm-commits]

akuegel added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/RegisterBankInfo.cpp:63
+  for (unsigned Idx = 0, End = getNumRegBanks(); Idx != End; ++Idx)
+    RegBanks[Idx]->HwMode = HwMode;
 #ifndef NDEBUG
----------------
bkramer already commented on this on the llvm-commits mailing list. Copying it here for visibility:

This can write to a global variable, which is thread-hostile. I see
tsan complain about concurrent writes to llvm::X86::GPRRegBank.

I reverted the patch (commit baa6f6a7828a46c37b96227282938717220f8b34).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76007/new/

https://reviews.llvm.org/D76007