[PATCH] D75987: [mlir][AVX512] Start a primitive AVX512 dialect

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache marked 11 inline comments as done.
nicolasvasilache added inline comments.


================
Comment at: mlir/include/mlir/IR/OpImplementation.h:111
   }
-  template <typename TypeRange>
-  void printArrowTypeList(TypeRange &&types) {
+  template <typename TypeRange> void printArrowTypeList(TypeRange &&types) {
     auto &os = getStream() << " -> ";
----------------
ftynse wrote:
> Use git-clang-format to avoid spurious reformatting in future commits
I have, it is another one of those cases where the config in phab does not agree. 
@mehdi_amini and @jpienaar are the most up to date on this.
Forcing manually to what phab wants.


================
Comment at: mlir/include/mlir/IR/OpImplementation.h:602
   /// Parse a type of a specific type.
-  template <typename TypeT>
-  ParseResult parseType(TypeT &result) {
+  template <typename TypeT> ParseResult parseType(TypeT &result) {
     llvm::SMLoc loc = getCurrentLocation();
----------------
same here re format


================
Comment at: mlir/lib/Conversion/AVX512ToLLVM/ConvertAVX512ToLLVM.cpp:185
+  target.addLegalDialect<LLVM::AVX512Dialect>();
+  // TODO(ntv): Ops in the td file need to be split to avoid adding the
+  // following manually.
----------------
ftynse wrote:
> We can go full metaprogramming and generate this function (and potentially the intrinsic-related ops as well)
Ack


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75987/new/

https://reviews.llvm.org/D75987