[PATCH] D75837: Introduce std.execute_region op

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 19 18:40:05 PDT 2020


mehdi_amini added a comment.

> Lambdas often allow both captures and arguments.

Yes: and they serve very different purpose, they have different well. 
Basically it seems like using different construct to model different concepts is fairly standard and undisputed.

> Is there a fundamental reason to disallow arguments in your op?

Seems like this is adding extra complexity, but I haven't seen a reason to motivate it. This seems like a good enough reason to me?

As I mentioned before, why wouldn't a canonicalize pattern just eliminate all the operands? And if so why do we allow it in the first place?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75837/new/

https://reviews.llvm.org/D75837





More information about the llvm-commits mailing list