[PATCH] D76378: [Attributor] Make use of analysis in the MustBeExecutedExplorer

Thu Mar 19 17:36:02 PDT 2020

jdoerfert added inline comments.

================
Comment at: llvm/test/Transforms/Attributor/dereferenceable-2.ll:400
+  ret i32 1
+}
----------------
sstefan1 wrote:
> uenoku wrote:
> > baziotis wrote:
> > > jdoerfert wrote:
> > > > TBH, I'm confused why this works. this test is only run in the old pass manager which doesn't support querying analysis passes (from the Attributor). Where am I wrong?
> > > That makes sense. I tested locally and it doesn't pass, maybe I miss something too though.
> > Sorry, I have missed this test uses OPM. It doesn't pass locally. 
> Could be that he didn't re-run the tests, since it should have worked with previous diff that didn't use `AnalysisGetter`.
FWIW, the solution here is to verify this works in the new pass manager ;), hence add a run line and different check lines for the new PM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76378/new/

https://reviews.llvm.org/D76378