[PATCH] D76399: [WebAssembly] SIMD integer abs instructions

[Thomas Lively via Phabricator via llvm-commits]

tlively marked an inline comment as done.
tlively added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:130
+    for (auto T : {MVT::v16i8, MVT::v8i16, MVT::v4i32})
+      setOperationAction(ISD::ABS, T, Legal);
+
----------------
aheejin wrote:
> Out of curiosity, before this patch, how was `ISD::ABS` lowered, given that there's no mention of lowering `ABS` in this file? If it was expanded, wasn't something like `setOperationAction(ISD::ABS, T, Expand)` supposed to be in this file?
ABS is one of the nodes that are expanded by default in TargetLoweringBase: https://github.com/llvm/llvm-project/blob/master/llvm/lib/CodeGen/TargetLoweringBase.cpp#L638-L666


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76399/new/

https://reviews.llvm.org/D76399