[PATCH] D76461: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs

Dan Albert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 19 17:00:17 PDT 2020


danalbert added a comment.

Thanks for fixing this 👍



================
Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:904
+               ? object::Archive::K_DARWIN
+               : object::Archive::K_GNU;
+    }
----------------
Looks like there are a few more options: https://llvm.org/doxygen/classllvm_1_1object_1_1Archive.html#ab288378fa8bfa0678dd25e36b5198a87. I think this regresses behavior for those other hosts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76461/new/

https://reviews.llvm.org/D76461





More information about the llvm-commits mailing list