[PATCH] D76463: [MLIR] Interfaces need to used add_mlir_library

Stephen Neuendorffer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 19 17:00:16 PDT 2020


stephenneuendorffer created this revision.
Herald added subscribers: llvm-commits, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar, rriddle, mehdi_amini, mgorny.
Herald added a project: LLVM.

The Interface libraries were moved from Analysis, but declared in
cmake using add_llvm_library().  This breaks LLVM_BUILD_LLVM_DYLIB
builds.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D76463

Files:
  mlir/lib/Interfaces/CMakeLists.txt


Index: mlir/lib/Interfaces/CMakeLists.txt
===================================================================
--- mlir/lib/Interfaces/CMakeLists.txt
+++ mlir/lib/Interfaces/CMakeLists.txt
@@ -7,7 +7,7 @@
   SideEffects.cpp
   )
 
-add_llvm_library(MLIRCallInterfaces
+add_mlir_library(MLIRCallInterfaces
   CallInterfaces.cpp
 
   ADDITIONAL_HEADER_DIRS
@@ -21,7 +21,7 @@
   MLIRIR
   )
 
-add_llvm_library(MLIRControlFlowInterfaces
+add_mlir_library(MLIRControlFlowInterfaces
   ControlFlowInterfaces.cpp
 
   ADDITIONAL_HEADER_DIRS
@@ -35,7 +35,7 @@
   MLIRIR
   )
 
-add_llvm_library(MLIRDerivedAttributeOpInterface
+add_mlir_library(MLIRDerivedAttributeOpInterface
   DerivedAttributeOpInterface.cpp
 
   ADDITIONAL_HEADER_DIRS
@@ -49,7 +49,7 @@
   MLIRIR
   )
 
-add_llvm_library(MLIRInferTypeOpInterface
+add_mlir_library(MLIRInferTypeOpInterface
   InferTypeOpInterface.cpp
 
   ADDITIONAL_HEADER_DIRS
@@ -63,7 +63,7 @@
   MLIRIR
   )
 
-add_llvm_library(MLIRLoopLikeInterface
+add_mlir_library(MLIRLoopLikeInterface
   LoopLikeInterface.cpp
 
   ADDITIONAL_HEADER_DIRS
@@ -77,7 +77,7 @@
   MLIRIR
   )
 
-add_llvm_library(MLIRSideEffects
+add_mlir_library(MLIRSideEffects
   SideEffects.cpp
 
   ADDITIONAL_HEADER_DIRS


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76463.251502.patch
Type: text/x-patch
Size: 1227 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200320/d048fc8e/attachment.bin>


More information about the llvm-commits mailing list