[PATCH] D76458: Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) [by modifying X86RetpolineThunks.cpp]

[Zola Bridges via Phabricator via llvm-commits]

zbrid added inline comments.


================
Comment at: llvm/lib/Target/X86/X86.td:437
+    : SubtargetFeature<
+          "lvi-cfi", "UseLVIControlFlowIntegrity", "true",
+          "Prevent indirect calls/branches from using a memory operand, and "
----------------
Also to follow up on the discussion earlier about SESES using the lvi-cfi subtarget feature for mitigating other issues as well.

Would it be possible to rename the subtarget specific to be more generic? I came up with a couple options: spex-cfi? speculative execution-cfi? se-cfi? side-channel-cfi? I don't know if that's too broad or not precise enough. The `lvi-cfi` flag should remain in Clang for sure, but I'd want to enable the subtarget feature for SESES which may not be used only for LVI.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76458/new/

https://reviews.llvm.org/D76458