[PATCH] D76047: [MLIR] Add support for out of tree external projects using MLIR

Thu Mar 19 16:28:04 PDT 2020

stephenneuendorffer added a comment.

In D76047#1931722 <https://reviews.llvm.org/D76047#1931722>, @jeanPerier wrote:

> Hi, thanks for improving the way one can plugin MLIR ! While trying to rebase our f18 project <https://github.com/flang-compiler/f18> that uses MLIR after this patch, I had a cmake issue using installed LLVMs out-of-tree, I tracked it to one of the line in this patch (see in-lined comment).

This code  is partially copied from clang., and it looks like clang has the same issue, if CLANG_HAS_EXPORTS is not set.  The big difference is that there is currently no mechanism to set MLIR_HAS_EXPORTS, so this will always get triggered.  I think your EXISTS check is probably the best fix.  I'll put together a patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76047/new/

https://reviews.llvm.org/D76047