[PATCH] D76428: [cmake] Disable C4129 warning for MSVC.

Thu Mar 19 15:54:37 PDT 2020

amccarth added a comment.

In D76428#1932174 <https://reviews.llvm.org/D76428#1932174>, @rnk wrote:

> I messed around with this in godbolt and couldn't reproduce the warning with any version that I tried:
>  https://gcc.godbolt.org/z/7-c8oa
>  Not sure if my example works, though.

The key is that the raw string has to be an argument to a macro that then tries to stringify the argument.

The vectorizing tests mentioned in this thread are indeed generating the error with VS 2019.

> I couldn't get any old versions to miscompile as Adrian described either, but I didn't test all versions exhaustively.

To see that, I think you have to go farther back than Compiler Explorer currently offers, like 19.0.

Given this information, I'm OK with this patch.  In an ideal world, I'd hope for a more localized fix, but then the problem would probably crop up again and again.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76428/new/

https://reviews.llvm.org/D76428