[PATCH] D75865: Introduce unify-loop-exits pass.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/UnifyLoopExits.cpp:32
+
+  void getAnalysisUsage(AnalysisUsage &AU) const {
+    AU.addRequired<LoopInfoWrapperPass>();
----------------
This seem to ignore the existence of switches (and call_br, but we don't handle that at all). Should this add a dependency on LowerSwitch (and preserve it)? Also should add a switch test or two


================
Comment at: llvm/lib/Transforms/Utils/UnifyLoopExits.cpp:152
+      for (auto Exit : Exits) {
+        dbgs() << " " << Exit->getName() << "";
+      }
----------------
Printing empty string?


================
Comment at: llvm/lib/Transforms/Utils/UnifyLoopExits.cpp:154
+      }
+      dbgs() << "\n";
+
----------------
single quotes


================
Comment at: llvm/lib/Transforms/Utils/UnifyLoopExits.cpp:158
+      for (auto EB : ExitingBlocks) {
+        dbgs() << " " << EB->getName();
+      }
----------------
single quotes


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75865/new/

https://reviews.llvm.org/D75865