[PATCH] D76293: [WIP][DebugInfo] refactor DIE classes. Remove dependency on AsmPrinter.

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 19 14:15:53 PDT 2020


avl added a comment.

> Could you point to where this is a requirement? (has this already been discussed in review/found to be an unacceptable dependency? llvm-dsymutil uses the existing AsmPrinter-based APIs to write the output, yes?)

So far, LLD folks generally do not object adding AsmPrinter if overall impact would be acceptable.

I think I could continue with AsmPrinter for now. Though it looks a bit overcomplicated solution. Simple writer like llvm/include/llvm/DebugInfo/GSYM/FileWriter.h would be more appropriate solution generally.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76293/new/

https://reviews.llvm.org/D76293





More information about the llvm-commits mailing list