[PATCH] D75131: [llvm-objdump][XCOFF][AIX] Implement -r option

Jason Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 19 12:33:06 PDT 2020


jasonliu marked an inline comment as done.
jasonliu added inline comments.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:22
+enum : uint16_t { NO_REL_MASK = 0x0001 };
+} // namespace
 
----------------
MaskRay wrote:
> Is the anonymous namespace useful?
I think it's good for internal linkage, and make it unreachable from other translation units.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75131/new/

https://reviews.llvm.org/D75131





More information about the llvm-commits mailing list