[PATCH] D76290: [lit] Allow passing extra commands to executeShTest

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 19 12:00:11 PDT 2020


delcypher added inline comments.


================
Comment at: llvm/utils/lit/lit/TestRunner.py:1492
+                  extra_substitutions=[],
+                  extra_commands=[]):
     if test.config.unsupported:
----------------
I don't think `extra_commands` is a command good name. It's not obvious that these are injected as extra commands at the beginning. Here are a few name suggestions

* `preamble_commands`
* `prologue_commands`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76290/new/

https://reviews.llvm.org/D76290





More information about the llvm-commits mailing list