[PATCH] D73568: Remove lit feature object-emission

Thu Mar 19 09:11:10 PDT 2020

vsk added a comment.

In D73568#1931433 <https://reviews.llvm.org/D73568#1931433>, @probinson wrote:

> In D73568#1927929 <https://reviews.llvm.org/D73568#1927929>, @vsk wrote:
>
> > If 'object-emission' is gone, can we fix this by removing all instances of 'REQUIRES: x86'?
>
>
> Interesting.  I'd have thought this would match an x86_64-foo-foo target triple, but perhaps not.
>  In any case, tests under an X86 directory should not need an explicit REQUIRES because the lit.local.cfg takes care of that.

Yeah, I think the available features checks require an exact match (not sure if wildcards are supported, but in any case there was no wildcard used here).

I'll look into re-enabling the tests now. Removing the 'REQUIRES' line is simple enough but as the tests were disabled for a while, several of them are broken.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73568/new/

https://reviews.llvm.org/D73568