[PATCH] D76428: [cmake] Disable C4129 warning for MSVC.

[Florian Hahn via Phabricator via llvm-commits]

fhahn created this revision.
fhahn added reviewers: RKSimon, rnk, dblaikie, foad.
Herald added a subscriber: mgorny.
Herald added a project: LLVM.

This patch disables C4129 warnings ("'character' : unrecognized
character escape sequence"), because MSVC also warns about them in raw
string literals. This leads to spurious warnings for changes, e.g. for
the code introduced in D73078 <https://reviews.llvm.org/D73078>.

Unfortunately I do not have access to MSVC to test this change.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D76428

Files:
  llvm/cmake/modules/HandleLLVMOptions.cmake


Index: llvm/cmake/modules/HandleLLVMOptions.cmake
===================================================================
--- llvm/cmake/modules/HandleLLVMOptions.cmake
+++ llvm/cmake/modules/HandleLLVMOptions.cmake
@@ -552,6 +552,8 @@
           # v15.8.8. Re-evaluate the usefulness of this diagnostic when the bug
           # is fixed.
       -wd4709 # Suppress comma operator within array index expression
+      -wd4129 # Suppress ''character' : unrecognized character escape sequence'
+          # warning, because MSVC also warns about them in raw string  literals.
 
       # Ideally, we'd like this warning to be enabled, but even MSVC 2019 doesn't
       # support the 'aligned' attribute in the way that clang sources requires (for


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76428.251362.patch
Type: text/x-patch
Size: 740 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200319/ab68d638/attachment.bin>