[PATCH] D76140: [InlineFunction] update attributes during inlining

Thu Mar 19 06:27:07 PDT 2020

anna added a comment.

In D76140#1930078 <https://reviews.llvm.org/D76140#1930078>, @reames wrote:

> In D76140#1927909 <https://reviews.llvm.org/D76140#1927909>, @anna wrote:
>
> > the test failures are related to attributes now being added to the calls in clang tests. All of these tests are using `llvm` intrinsics. Should we just disable this for intrinsic calls for now? Not sure how to update clang tests in the same patch as llvm project. Should be doable though.
>
>
> Er, git is monorepo.  Those tests should be checked out alongside your LLVM copy.  You just need to build clang.  You can and should simply update the tests in the same patch.

ah yes, I'd build llvm within it's own subdir without enabling any other projects. Build worked. thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76140/new/

https://reviews.llvm.org/D76140