[PATCH] D76425: [llvm-readobj] Allow syms from all sections to match stack size entries

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/stack-sizes.test:156
+    Binding: STB_GLOBAL
+  ## sh_link is ignored for executables.
+  - Name:    other
----------------
Perhaps say which sh_link?

```
sh_link of `.stack_sizes` is ...
```

> executables

and DSOs?


================
Comment at: llvm/test/tools/llvm-readobj/ELF/stack-sizes.test:163
+  ## If two symbols have the same value, the first is picked, regardless of
+  ## sh_link.
+  - Name:    other_end
----------------
BTW, does would it be better to print all of candidates?
e.g:


```
Size   Function
16     other
32     other_end/foo/bar
```



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5354
       uint64_t SymValue = Data.getAddress(&Offset);
-      printFunctionStackSize(Obj, SymValue, Obj->toSectionRef(FunctionELFSec),
-                             SectionName, Data, &Offset);
+      printFunctionStackSize(Obj, SymValue, None, SectionName, Data, &Offset);
     }
----------------
/*FunctionSec=*/None


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76425/new/

https://reviews.llvm.org/D76425