[PATCH] D76238: [SveEmitter] Implement builtins for contiguous loads/stores

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7467
+
+  return IsZxtReturn ? Builder.CreateZExt(Load, VectorTy)
+                     : Builder.CreateSExt(Load, VectorTy);
----------------
sdesmalen wrote:
> SjoerdMeijer wrote:
> > nit: and now looking at this, this can be a zero or sign extend, so `Zxt` is slightly misleading?
> The default is sign-extend, so we added a flag for the case where a zero-extend is needed/expected. Are you suggesting to rename the flag or to add an extra flag for IsSxt?
I don't know to be honest, it was a nit anyway, but whatever you think is best. But just reading the name `IsZxtReturn`, I was only expecting a zero-extend.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76238/new/

https://reviews.llvm.org/D76238