[PATCH] D76281: [obj2yaml] - Stop dumping an empty sh_info field for SHT_RELA/SHT_REL sections.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 19 03:45:09 PDT 2020
grimar marked an inline comment as done.
grimar added inline comments.
================
Comment at: llvm/test/tools/obj2yaml/rel-rela-section.yaml:30-33
+## Add at least one symbol to trigger the .dynsym emission.
+DynamicSymbols:
+ - Name: bar
+ Binding: STB_GLOBAL
----------------
jhenderson wrote:
> I'm fine either way, but can't this be simply `DynamicSymbols: []`? I thought that created a dynsym with the null symbol in only?
Right. Seems I've forgot to clean-up this piece that comes from the test I am removing.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76281/new/
https://reviews.llvm.org/D76281
More information about the llvm-commits
mailing list