[PATCH] D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols.

Thu Mar 19 03:44:58 PDT 2020

grimar added a comment.

In D75756#1930897 <https://reviews.llvm.org/D75756#1930897>, @Higuoxing wrote:

> In D75756#1930888 <https://reviews.llvm.org/D75756#1930888>, @grimar wrote:
>
> > > Can we do this in next few patches? It seems that we have to resolve some continue; and break; statements.
> >
> > I think we should commit the nice code from start. If we can't because of a minor refactoring needed, this refactoring should be done first.
>
>
> Sure. Let me have a try, thanks a lot.

I think you can just do it in this patch: separating the code to a helper function is a normal common thing that is often done.
Probably no need to create a separate revision, since this refactoring is needed for changes you do right here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75756/new/

https://reviews.llvm.org/D75756