[PATCH] D75672: [ValueTypes] Add support for scalable EVTs

Cullen Rhodes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 19 02:39:34 PDT 2020


c-rhodes marked an inline comment as not done.
c-rhodes added a comment.

Thanks for reviewing Eli!



================
Comment at: llvm/include/llvm/CodeGen/ValueTypes.h:257
     EVT getVectorElementType() const {
-      assert(isVector() && "Invalid vector type!");
+      assert((isVector() || isScalableVector()) && "Invalid vector type!");
       if (isSimple())
----------------
efriedma wrote:
> `isVector() || isScalableVector()` is the same thing as `isVector()`, I think?
Yeah `isVector()` looks sufficient, I'll fix before merging.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75672/new/

https://reviews.llvm.org/D75672





More information about the llvm-commits mailing list