[PATCH] D76413: [mlir][Linalg] NFC: Clean up for 0-D abstraction.

[Mahesh Ravishankar via Phabricator via llvm-commits]

mravishankar accepted this revision.
mravishankar added a comment.
This revision is now accepted and ready to land.

Just one suggestion since you are touching these anyways



================
Comment at: mlir/lib/Dialect/Linalg/Transforms/LinalgToLoops.cpp:321
 
     // 1.b. Emit std_load from output views.
     for (unsigned i = 0; i < nOutputs; ++i) {
----------------
This is unrelated to the change, but you can avoid doing these loads here if the corresponding argument of the region has no uses. Would be a bonus to do this here.
I think doing that in a separate change is fine. Can you just add a todo for me here if you dont get to it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76413/new/

https://reviews.llvm.org/D76413