[PATCH] D75837: Introduce std.execute_region op

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/include/mlir/Dialect/StandardOps/IR/Ops.td:974
+//===----------------------------------------------------------------------===//
+// ExecuteRegionOp
+//===----------------------------------------------------------------------===//
----------------
This op comes before ExtractElementOp alphabetically.


================
Comment at: mlir/include/mlir/Dialect/StandardOps/IR/Ops.td:984
+      have multiple blocks and the blocks can have terminators the same way as
+      MLIR functions (FuncOp) do. The values returned from this op's region
+      define the op's results. The op primarily provides control flow
----------------
nit: MLIR functions (FuncOp) -> FuncOp


================
Comment at: mlir/include/mlir/Dialect/StandardOps/IR/Ops.td:994
+
+      loop.for %i = 0 to 128 {
+        %y = execute_region -> i32 {
----------------
This should be indented in an mlir code block


================
Comment at: mlir/lib/Dialect/StandardOps/IR/Ops.cpp:1388
+
+//
+// (ssa-id `=`)? `execute_region` `->` function-result-type `{`
----------------
Use /// For top-level comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75837/new/

https://reviews.llvm.org/D75837