[PATCH] D76403: Add Builder::get{I32,I64}TensorAttr.

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula added inline comments.


================
Comment at: mlir/include/mlir/IR/Builders.h:119
 
+  /// Vector-typed DenseIntElementsAttr getters. Cannot be empty.
   DenseIntElementsAttr getI32VectorAttr(ArrayRef<int32_t> values);
----------------
Nit: Cannot be empty -> `values` cannot be empty


================
Comment at: mlir/include/mlir/IR/Builders.h:123
 
+  /// Tensor-typed DenseInteElementsAttr getters. Allowed to be empty.
+  /// These are generally preferable for representing general lists of integers
----------------
Likewise. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76403/new/

https://reviews.llvm.org/D76403