[PATCH] D76285: [X86][MC] Fix the bug for prefix padding support

[Kan Shengchen via Phabricator via llvm-commits]

skan marked 2 inline comments as done.
skan added inline comments.


================
Comment at: llvm/test/MC/X86/align-branch-64-basic.s:106
 
-  # CHECK: <test_pad_via_relax>:
-  # CHECK: 200: testq
----------------
reames wrote:
> Please restore this test and show any diff.  This test is not an unimplemented case, it's testing the jne being relaxed which is happening.
Why do you think we can relax this jne to reduce nops? This jne is after boundaryalign.


================
Comment at: llvm/test/MC/X86/align-branch-64-pad-max-prefix.s:10
+  # We should not increase the length of this jmp to reduce the bytes of
+  # following nops, doing so would make the jmp misaligned.
+# CHECK:      18:          jmp
----------------
reames wrote:
> This case should already be handled by skipping instructions past the branch align.
No, it's not handled.  Your can run this test case without this patch to prove.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76285/new/

https://reviews.llvm.org/D76285