[PATCH] D76176: [X86] Disable nop padding before instruction following hardcode

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

FYI, this patch (and the previous prefix handling) is incomplete.  For both of them, you need to prevent not just nop insertion, but also prefix insertion.  I don't think this is really a problem for the compiler use case (as we already have the suppression mechanism), but since you seem set on supporting arbitrary assembly I wanted to point that out.  I still think that is a bad idea and that you're better off defining syntax for an opt in system.

We probably need some form of a marker on the fragment or a separate fragment to mark a boundary it is unsafe to pad.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76176/new/

https://reviews.llvm.org/D76176