[PATCH] D76326: Introduced CallOp Dialect Conversion

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 18 17:24:08 PDT 2020


rriddle accepted this revision.
rriddle added a comment.
This revision is now accepted and ready to land.

LGTM after resolving last comments.



================
Comment at: mlir/include/mlir/Conversion/StandardToStandard/StandardToStandard.h:1
+//===- DialectConversion.h - MLIR dialect conversion pass -------*- C++ -*-===//
+//
----------------
This needs to be updated.


================
Comment at: mlir/lib/Conversion/StandardToStandard/DialectConversion.cpp:1
+//===- DialectConversion.cpp - Test dialect pattern driver ----------------===//
+//
----------------
Can we name this file the same as the header?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76326/new/

https://reviews.llvm.org/D76326





More information about the llvm-commits mailing list