[PATCH] D76288: [lit] Add builtin support for flaky tests in lit

Louis Dionne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 18 15:13:45 PDT 2020


ldionne added a comment.

In D76288#1927738 <https://reviews.llvm.org/D76288#1927738>, @yln wrote:

> LGTM, with one quick ask to add 2 more tests to document the behavior/intereaction with `config.test_retry_attempts`:
>
> - `test_retry_attempts` (without `ALLOW_RETRIES`) should still be respected (this test should have been there in the first place).
> - `ALLOW_RETRIES` overwrites `test_retry_attempts`, when both are specified.


Thanks for the feedback, I implemented the tests. I'll commit now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76288/new/

https://reviews.llvm.org/D76288





More information about the llvm-commits mailing list