[PATCH] D75476: [mlir] Add support for detecting single use callables in the Inliner.

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/lib/Transforms/Inliner.cpp:192
+  };
+  walkSymbolTables(op, /*opIsHidden=*/!op->getBlock(), walkFn);
+
----------------
mehdi_amini wrote:
> I don't quite get the `!op->getBlock()`?'
> (top-level module isn't hidden but isn't in a block)
Renamed to `allSymUsesVisibile` to make it clear. It means that the uses are hidden from other operations, i.e. can't be referenced. It essentially means that we can assume that all symbol uses are visible to the use list.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75476/new/

https://reviews.llvm.org/D75476