[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

Jason Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 18 13:02:05 PDT 2020


jasonliu added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-cc-abi-va_args-32.ll:1
+; RUN: llc -O2 -mtriple powerpc-ibm-aix-xcoff -stop-after=machine-cp -mattr=-altivec -verify-machineinstrs < %s | \
+; RUN: FileCheck --check-prefixes=CHECK,32BIT %s
----------------
Do we need '-O2' specified here and below?


================
Comment at: llvm/test/CodeGen/PowerPC/aix-cc-abi-va_args-32.ll:15
+
+ at a = local_unnamed_addr global i32 1, align 4
+ at b = local_unnamed_addr global i32 2, align 4
----------------
These variables didn't get used anywhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76130/new/

https://reviews.llvm.org/D76130





More information about the llvm-commits mailing list