[PATCH] D75224: [SelectionDAG][FPEnv] Take into account SelectionDAG continuous CSE when setting the nofpexcept flag for constrained intrinsics

Wed Mar 18 13:02:04 PDT 2020

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

In D75224#1927879 <https://reviews.llvm.org/D75224#1927879>, @craig.topper wrote:

> Fix typo in comment.
>
> For reductions, do you think we can just check that the reduction flag is already set? Or do we need to just excluse all BinaryOperators from the geneirc handler and just fully manage FMF for BinaryOperators in its visitor function?

Just checking the flag seems like it should work, but I haven't stepped through a reduction example, so I'm not sure.
Either way, let's push this change and see if it uncovers any other flag problems. LGTM.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75224/new/

https://reviews.llvm.org/D75224