[PATCH] D76363: [MLIR] Add parallel loop coalescing.

Uday Bondhugula via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 18 10:52:48 PDT 2020


bondhugula requested changes to this revision.
bondhugula added a comment.
This revision now requires changes to proceed.

Could you please add a summary to the commit message - even if it's a couple of lines? On a side note, do you want to use the term 'collapse' instead of 'coalesce'? OpenMP uses collapse for such linearization, and coalesce could also imply fusion of loops, which this isn't. I do see that colaesceLoops already existed prior to this patch



================
Comment at: mlir/lib/Transforms/ParallelLoopCoalescing.cpp:52
+    func.walk([&](loop::ParallelOp op) {
+      std::vector<std::vector<unsigned>> combinedLoops(3);
+      combinedLoops[0] = clCoalescedIndices0;
----------------
List initialize?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76363/new/

https://reviews.llvm.org/D76363





More information about the llvm-commits mailing list