[PATCH] D76303: [Pipeliner] Fix the bug in pragma that disables the pipeliner
Sumanth Gundapaneni via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 18 08:42:07 PDT 2020
sgundapa marked an inline comment as done.
sgundapa added inline comments.
================
Comment at: llvm/lib/CodeGen/MachinePipeliner.cpp:295
+ disabledByPragma = false;
+
if (S->getString() == "llvm.loop.pipeline.initiationinterval") {
----------------
avl wrote:
> now it becomes depending on order of metadata. It works for "distinct !{!8, !7, !9}" and does not work for distinct !{!8, !9, !7} . This default value should be set in the first line of setPragmaPipelineOptions (before other instructions):
>
>
> ```
> void MachinePipeliner::setPragmaPipelineOptions(MachineLoop &L) {
> disabledByPragma = false;
> ```
I did not realize this is inside the loop. I will move this before we start executing this loop.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76303/new/
https://reviews.llvm.org/D76303
More information about the llvm-commits
mailing list