[PATCH] D75131: [XCOFF][AIX] Enable -r option for llvm-objdump

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added a comment.

I believe all of the previous comments have been addressed or discussed. I have just some minor comments.



================
Comment at: llvm/include/llvm/Object/XCOFFObjectFile.h:18
 #include "llvm/Object/ObjectFile.h"
+#include <limits>
 
----------------
I'm not a fan of increasing inclusions in an interface header.


================
Comment at: llvm/include/llvm/Object/XCOFFObjectFile.h:252
+  static constexpr uint64_t InvalidRelocOffset =
+      std::numeric_limits<uint64_t>::max();
+
----------------
`0xffffffff'ffffffffULL`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75131/new/

https://reviews.llvm.org/D75131