[PATCH] D75976: [AMDGPU] Optimize AtomicOptimizer

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 18 08:09:06 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAtomicOptimizer.cpp:530
+      // currently hard to do though it might work when GlobalISel gets used.
+      CallInst *const CtpopCall = B.CreateUnaryIntrinsic(Intrinsic::ctpop, Ballot);
+      CtpopCall->addAttribute(AttributeList::FunctionIndex, Attribute::Convergent);
----------------
This won't be preserved in any meaningful way to th backend, this should be removed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75976/new/

https://reviews.llvm.org/D75976





More information about the llvm-commits mailing list