[PATCH] D76350: [mlir] lower loop.if operations that yield a result

[Tobias Gysi via Phabricator via llvm-commits]

gysit added a comment.

In D76350#1928810 <https://reviews.llvm.org/D76350#1928810>, @ftynse wrote:

> Unfortunately, this is harder than it looks. We need to make sure all IR changes in the pattern go through `rewriter` and we currently don't have a way of adding new block arguments there. If you are blocked by this, feel free to temporarily loop.if lowering from the pattern rewriter infra and run it as a plain IR-mutating pass.


Thanks for that hint!

I guess I have multiple patterns where I use replaceAllUsesWith(). Can a rollback happen even if there is no code path that later on returns failure()? I ask since my stuff seems to work so far.

Let's postpone the patch then!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76350/new/

https://reviews.llvm.org/D76350