[PATCH] D76352: [llvm-readobj] Derive dynamic symtab size from hash table
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 18 05:57:31 PDT 2020
grimar added inline comments.
================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5924
}
}
----------------
Perhaps, the following piece looks slightly better.
```
StringRef Name= "<?>";
if (!this->dumper()->getElfObject()->sections().empty()) {
if (Expected<StringRef> SectionName =
this->dumper()->getSymbolSectionName(Symbol, *SectionIndex))
Name = *SectionName;
else
this->reportUniqueWarning(SectionName.takeError());
}
W.printHex("Section", Name, *SectionIndex);
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76352/new/
https://reviews.llvm.org/D76352
More information about the llvm-commits
mailing list