[PATCH] D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0

[Xing via Phabricator via llvm-commits]

Higuoxing updated this revision to Diff 251033.
Higuoxing marked an inline comment as done.
Higuoxing added a comment.

Update comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76081/new/

https://reviews.llvm.org/D76081

Files:
  llvm/include/llvm/Object/ELFObjectFile.h


Index: llvm/include/llvm/Object/ELFObjectFile.h
===================================================================
--- llvm/include/llvm/Object/ELFObjectFile.h
+++ llvm/include/llvm/Object/ELFObjectFile.h
@@ -1019,8 +1019,14 @@
 
 template <class ELFT>
 elf_symbol_iterator ELFObjectFile<ELFT>::dynamic_symbol_begin() const {
-  DataRefImpl Sym = toDRI(DotDynSymSec, 0);
-  return symbol_iterator(SymbolRef(Sym, this));
+  if (!DotDynSymSec || !DotDynSymSec->sh_size ||
+      DotDynSymSec->sh_size % sizeof(Elf_Sym) != 0) {
+    // We are ignoring errors that sh_size doesn't match symbol entries.
+    return symbol_iterator(SymbolRef(toDRI(DotDynSymSec, 0), this));
+  } else {
+    // Skip 0-index NULL symbol.
+    return symbol_iterator(SymbolRef(toDRI(DotDynSymSec, 1), this));
+  }
 }
 
 template <class ELFT>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76081.251033.patch
Type: text/x-patch
Size: 819 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200318/4314b477/attachment.bin>