[PATCH] D76265: [PowerPC] add IR level isFMAFasterThanFMulAndFAdd - NFC

[qshanz via Phabricator via llvm-commits]

steven.zhang added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:15304
                                                    EVT VT) const {
   VT = VT.getScalarType();
 
----------------
shchenz wrote:
> steven.zhang wrote:
> > Don't get the scalar type as the parameter of "Ty" in IR version is the type of the function.
> I think You mean in IR version, I already call `getScalarType()` , so no need to call it again?
My understanding is that, these two hooks have completely the same semantics basing on different data structure. We should pass through the type instead of strip the vector type. And it doesn't make sense as the decision is made inside IR version hook, we cannot make any assumption that it didn't care about the vector type.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76265/new/

https://reviews.llvm.org/D76265