[PATCH] D76265: [PowerPC] add IR level isFMAFasterThanFMulAndFAdd - NFC

Tue Mar 17 23:58:58 PDT 2020

shchenz added a comment.

In D76265#1928272 <https://reviews.llvm.org/D76265#1928272>, @steven.zhang wrote:

> In D76265#1928228 <https://reviews.llvm.org/D76265#1928228>, @shchenz wrote:
>
> > In D76265#1928209 <https://reviews.llvm.org/D76265#1928209>, @steven.zhang wrote:
> >
> > > I don't think this is a NFC patch as you are adding hook for IR version.
> >
> >
> > The IR hook does not have any caller like NFC patches only adding a helper function without any caller?
>
>
> Well, that's really confusing to have hook without caller. And yes, it is NFC.

actually there is a user `isProfitableToHoist` in `AArch64` target for same purpose as what I do for this patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76265/new/

https://reviews.llvm.org/D76265