[PATCH] D76213: [llvm-nm] Add test for `--debug-syms --dynamic`

[Xing via Phabricator via llvm-commits]

Higuoxing updated this revision to Diff 250998.
Higuoxing added a comment.

Addressed comments.

- Remove test for `--debug-syms -D` (Leave it to a `--dynamic` dedicated test file)
- Use `--implicit-check-not {{.}}` for a more stringent check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76213/new/

https://reviews.llvm.org/D76213

Files:
  llvm/test/tools/llvm-nm/debug-syms.test


Index: llvm/test/tools/llvm-nm/debug-syms.test
===================================================================
--- llvm/test/tools/llvm-nm/debug-syms.test
+++ llvm/test/tools/llvm-nm/debug-syms.test
@@ -1,6 +1,17 @@
 # RUN: yaml2obj %s -o %t.o
-# RUN: llvm-nm --debug-syms %t.o | FileCheck %s --implicit-check-not U
-# RUN: llvm-nm -a %t.o | FileCheck %s --implicit-check-not U
+# RUN: llvm-nm --debug-syms %t.o | FileCheck %s --implicit-check-not {{.}} --check-prefix SYMBOL
+# RUN: llvm-nm -a %t.o | FileCheck %s --implicit-check-not {{.}} --check-prefix SYMBOL
+
+# SYMBOL:      0000000000000000 n $a
+# SYMBOL-NEXT: 0000000000000000 n $d
+# SYMBOL-NEXT: 0000000000000000 n $t
+# SYMBOL-NEXT: 0000000000000000 a file_sym
+# SYMBOL-NEXT: 0000000000000000 n section
+
+# RUN: llvm-nm --debug-syms --dynamic %t.o | FileCheck %s --implicit-check-not {{.}} --check-prefix DYNSYM
+
+# DYNSYM:      0000000000000000 N dynglobal
+# DYNSYM-NEXT: 0000000000000000 n dynlocal
 
 !ELF
 FileHeader:
@@ -24,9 +35,11 @@
     Section: section
   - Name:    $a
     Section: section
-
-# CHECK:      $a
-# CHECK-NEXT: $d
-# CHECK-NEXT: $t
-# CHECK-NEXT: file_sym
-# CHECK-NEXT: section
+DynamicSymbols:
+  - Name:    dynlocal
+    Type:    STT_OBJECT
+    Section: section
+  - Name:    dynglobal
+    Type:    STT_OBJECT
+    Binding: STB_GLOBAL
+    Section: section    


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76213.250998.patch
Type: text/x-patch
Size: 1363 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200318/7c02c4b6/attachment-0001.bin>