[PATCH] D76203: [mlir] Add a hook to PatternRewriter to allow for patterns to notify why a match failed.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 17 22:41:14 PDT 2020


mehdi_amini added inline comments.


================
Comment at: mlir/lib/Transforms/DialectConversion.cpp:1001
+  return failure();
+}
+
----------------
If this was in a header, we could try to rely on inlining to make it purely zero cost in release mode at call-sites by eliminating all the debug strings. Right now they would still be in the binary I think (LTO may help). Have you looked into this possibility?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76203/new/

https://reviews.llvm.org/D76203





More information about the llvm-commits mailing list