[PATCH] D76265: [PowerPC] add IR level isFMAFasterThanFMulAndFAdd - NFC

qshanz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 17 22:41:13 PDT 2020


steven.zhang added a comment.

In D76265#1928228 <https://reviews.llvm.org/D76265#1928228>, @shchenz wrote:

> In D76265#1928209 <https://reviews.llvm.org/D76265#1928209>, @steven.zhang wrote:
>
> > I don't think this is a NFC patch as you are adding hook for IR version.
>
>
> The IR hook does not have any caller like NFC patches only adding a helper function without any caller?


There must be caller for the IR hook, otherwise it won't be there. It is used by GISel.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76265/new/

https://reviews.llvm.org/D76265





More information about the llvm-commits mailing list